waypoints 0.05: implement goto functionality #3659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code still needs refactoring, but make lint happy for now.
pavelmachek
force-pushed
the
m_39_waypoints
branch
from
68145cc to
e631221
Compare
bobrippling
reviewed
Nov 19, 2024
| "" : {title : "Select WP"}, | ||
| "< Back" : mainMenu | ||
| }; | ||
| if (Object.keys(wp).length==0) Object.assign(menu, {"No WPs":""}); |
There was a problem hiding this comment.
Is wp always an array? If so we could:
Suggested change
| if (Object.keys(wp).length==0) Object.assign(menu, {"No WPs":""}); | |
| if (wp.length==0) Object.assign(menu, {"No WPs":""}); |
| if (Object.keys(wp).length==0) Object.assign(menu, {"No WPs":""}); | ||
| else { | ||
| wp.forEach((val, card) => { | ||
| const name = wp[card].name; |
There was a problem hiding this comment.
Here we could save a bit of code:
Suggested change
| const name = wp[card].name; | |
| const name = val.name; |
|
Yeah, there's ton more optimalizations/cleanups that could be done. I'd prefer this to be applied, then I can take your patches as a separate commit, do more work on top of that, and submit it as new version after some testing? |
|
Not a problem, that sounds like a plan :) |
|
Thank you, it makes my patch flow easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update libraries, refactor and implement goto functionality